-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub_filter_temperature flux #123
Comments
There's no minus signing missing in the sense that the quantity But, I do agree that the name of the function that yields a dictionary of these quantities is misleading. I think it does make sense to either 1. change the name of the function (but to what?) or 2. find a name for averages = Dict(
:τ¹³ => AveragedField(- ∂z(u) * νₑ, dims=(1, 2)),
:τ²³ => AveragedField(- ∂z(v) * νₑ, dims=(1, 2)),
:τ³³ => AveragedField(- ∂z(w) * νₑ, dims=(1, 2))
) The downside of this change is that " |
Oceananigans.jl calculates all interior and boundary contributions to tendency terms (for tracer and momentum) simultaneously. But I think the important question here is about diagnostics rather than Oceananigans source code calculations. When we perform diagnostics with Oceananigans, we are always computing terms after the fact. Oceananigans does not store components of the tendency that can be evaluated later. The subfilter tracer fluxes are defined as
On boundaries, the value of this diagnostic depends on boundary conditions. If a In this case, there is no contribution to boundary fluxes from the interior turbulence closure. The way to think about this model mathematically is that the user has specified a different model for fluxes across exterior boundaries than in the interior. The only way to recover those exterior fluxes is to save them explicitly as the model is running, or to write down their values if the fluxes are constant. If a user specifies a |
Thanks for your answers, @glwagner! We are trying to validate Oceananigans against several other LES schemes before using it for a larger project, so we wanted to make sure we were comparing apples to apples. It sounds like we were, and the distinction for I see your point on the dictionary/variable names vs. the function name. If you do want to retain the dictionary terms, perhaps the functions could have alternative names like |
Hello,
I and @BrodiePearson are running convective cases (only heat flux at surface). But when we analyze the second moments and subfilter fluxes using LESbrary, we encountered a few issues:
Does Oceananigans.jl consider the resolved, subfilter, and boundary flux separate?
Is there a minus sign missing in the downgradient computation? Turbulent fluxes are typically defined as minus the diffusivity multiplied by the gradient, but the code does not have this minus sign (in the plots below we flipped the sign of the diagnosed subfilter fluxes):
LESbrary.jl/src/TurbulenceStatistics/subfilter_fluxes.jl
Lines 24 to 28 in 374e758
LESbrary.jl/src/TurbulenceStatistics/subfilter_fluxes.jl
Line 48 in 374e758
The text was updated successfully, but these errors were encountered: