Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(wip) refactor: redo how data collection is laid out #1558

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

(wip) refactor: redo how data collection is laid out #1558

wants to merge 7 commits into from

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 19.18819% with 876 lines in your changes missing coverage. Please review.

Project coverage is 42.11%. Comparing base (76fb759) to head (30bb37b).

Files with missing lines Patch % Lines
...new_data_collection/sources/linux/processes/mod.rs 14.76% 254 Missing ⚠️
...c/new_data_collection/sources/linux/temperature.rs 31.64% 203 Missing ⚠️
...data_collection/sources/linux/processes/process.rs 0.00% 156 Missing ⚠️
src/new_data_collection/collectors/linux.rs 0.00% 56 Missing ⚠️
src/new_data_collection/sources/starship.rs 0.00% 31 Missing ⚠️
src/new_data_collection/sources/linux/memory.rs 0.00% 30 Missing ⚠️
src/new_data_collection/sources/sysinfo/cpu.rs 0.00% 28 Missing ⚠️
src/new_data_collection/sources/sysinfo/memory.rs 0.00% 27 Missing ⚠️
src/new_data_collection/sources/nvidia/memory.rs 0.00% 20 Missing ⚠️
...rc/new_data_collection/sources/common/processes.rs 0.00% 16 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1558       /-   ##
==========================================
  Coverage   41.84%   42.11%    0.27%     
==========================================
  Files         114      115        1     
  Lines       17672    17878      206     
==========================================
  Hits         7395     7530      135     
- Misses      10277    10348       71
Flag Coverage Δ
macos-12 ?
ubuntu-latest 42.11% <19.18%> (-1.49%) ⬇️
windows-2019 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang force-pushed the refactor_data_collection_again branch 2 times, most recently from 8fba8b1 to 58a5f3e Compare September 28, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ClementTsang