Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor styling options #1499

Merged
merged 17 commits into from
Jul 29, 2024
Merged

refactor: refactor styling options #1499

merged 17 commits into from
Jul 29, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jul 23, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Introduce a new configuration system for styling.

Issue

If applicable, what issue does this address?

Part of what will address #556

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 86.64122% with 70 lines in your changes missing coverage. Please review.

Project coverage is 41.59%. Comparing base (e4eb69d) to head (93a5321).

Files Patch % Lines
src/options/config/style/utils.rs 36.58% 26 Missing ⚠️
src/app.rs 0.00% 8 Missing ⚠️
src/options/config/style.rs 90.00% 7 Missing ⚠️
src/canvas/dialogs/dd_dialog.rs 0.00% 4 Missing ⚠️
src/canvas/widgets/battery_display.rs 0.00% 4 Missing ⚠️
src/canvas/widgets/process_table.rs 0.00% 4 Missing ⚠️
src/canvas/widgets/cpu_graph.rs 33.33% 2 Missing ⚠️
src/options.rs 94.28% 2 Missing ⚠️
src/widgets/cpu_graph.rs 77.77% 2 Missing ⚠️
src/canvas.rs 50.00% 1 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1499       /-   ##
==========================================
  Coverage   40.91%   41.59%    0.67%     
==========================================
  Files         103      110        7     
  Lines       17570    17187     -383     
==========================================
- Hits         7189     7149      -40     
  Misses      10381    10038     -343     
Flag Coverage Δ
macos-12 36.17% <86.25%> (-0.12%) ⬇️
ubuntu-latest 42.78% <86.64%> (-0.11%) ⬇️
windows-2019 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang force-pushed the bold_text_support branch 3 times, most recently from 1ac3f88 to 88c9340 Compare July 26, 2024 06:21
@ClementTsang ClementTsang changed the title feature: add bold text styling options refactor: refactor styling options Jul 28, 2024
@ClementTsang ClementTsang marked this pull request as ready for review July 28, 2024 08:01
@ClementTsang
Copy link
Owner Author

Left to do: update docs.

@ClementTsang ClementTsang enabled auto-merge (squash) July 29, 2024 08:54
@ClementTsang ClementTsang merged commit 28972a1 into main Jul 29, 2024
35 of 36 checks passed
@ClementTsang ClementTsang deleted the bold_text_support branch July 29, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant