Prevent StrawberryShake client throwing ArgumentNullException when @include directive is false. #7171
5
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an operation contains an
@include(if: false)
the generated code throws anArgumentNullException
at runtime.In the GraphQL Api I tried extracting @include directives using a middleware like this in order to return something other than null. Though this only works when @include(if: true) since the directive itself is not included in this scenario.
It would be good to apply this conditionally based on whether a directive exists but it seems directives are ignored by the StarwberryShake.CodeGeneration.Analyzers