Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend bar #53

Merged
merged 11 commits into from
Sep 13, 2023
Merged

Legend bar #53

merged 11 commits into from
Sep 13, 2023

Conversation

zmalkmus
Copy link
Collaborator

@zmalkmus zmalkmus commented Aug 30, 2023

Added a legend for the dynamic simulation. It now changes values based on the current state (v angle, v magnitude, and frequency).

Also cleaned up changed files and removed a redundant index.html file.

Default view
image

V Angle (min: -0.80, max: 0.2)
image

V Magnitude (min: -3.555 max: 3.01)
image

Frequency (min:0.9999 max: 1.0002)
image

Ability to be dragged
image

Deleting accidentally added output files.
Deleting accidentally added output files.
@zmalkmus zmalkmus added the enhancement New feature or request label Aug 30, 2023
@zmalkmus zmalkmus linked an issue Aug 30, 2023 that may be closed by this pull request
@jinningwang
Copy link
Member

Well done! Some minor comments:

  1. In the future, newly developed features might be merged into develop branch first, and we'll do the regular merge from branch to master regularly. In this way, we can have a better release manner.
  2. Would you mind putting a full screenshot here? So I can make sure the overall layout is okay.
  3. Are the range for the legend bar consistent with user settings?

@zmalkmus
Copy link
Collaborator Author

zmalkmus commented Aug 30, 2023 via email

@jinningwang
Copy link
Member

jinningwang commented Aug 30, 2023

Jinning, Ah, I was confused what the develop branch was for. I will do this in the future.

My practice would be to merge "patch" version feature1 -> develop, feature2 -> develop, etc.
After accumulating several patch versions, summarize them as a "minor" version, and dodevelop -> master. This is because some bugs or defects can be detected when using develop.
More details about versioning can be found at Semantic Versioning 2.0.0.

Here is the full view of the placement of the legend. [image: image.png]

It didn't load the actual page but the file name here.

As for the value ranges, thank you for catching this. I had mentally skipped over the possibility and assumed the values were static. Just to make sure I didn't miss anything, the range should correspond to the frequency min and max values in the configuration panel? I apologize for the mistake.
It's fine. Check the documentation about the customized value range, Nicholas should have mentioned this in the updated documentation.
We would expect the legend bar to be consistent with the user-input value range, so I feel this might need some more effort.

BTW, in the dynamic simulation, we have bus voltage, bus frequency, and bus angle. We might need to change the legend name accordingly if change the displayed variable.

@zmalkmus
Copy link
Collaborator Author

It didn't load the actual page but the file name here.

The image did not transfer correctly through email unfortunately. I have corrected the original image to show the full view.

As for the value ranges, thank you for catching this. I had mentally skipped over the possibility and assumed the values were static. Just to make sure I didn't miss anything, the range should correspond to the frequency min and max values in the configuration panel? I apologize for the mistake.
It's fine. Check the documentation about the customized value range, Nicholas should have mentioned this in the updated documentation.
We would expect the legend bar to be consistent with the user-input value range, so I feel this might need some more effort.

BTW, in the dynamic simulation, we have bus voltage, bus frequency, and bus angle. We might need to change the legend name accordingly if change the displayed variable.

I will make some event handlers to change the title and values as they get updated through use of the application. I will continue to work on this.

I appreciate your feedback.

@zmalkmus zmalkmus self-assigned this Sep 13, 2023
@jinningwang jinningwang merged commit b1810f3 into master Sep 13, 2023
@zmalkmus zmalkmus deleted the legend-bar branch December 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Add Legend Bar to Dynamic Results Visualization
2 participants