Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devdoc #48

Merged
merged 15 commits into from
Aug 2, 2023
Merged

Devdoc #48

merged 15 commits into from
Aug 2, 2023

Conversation

nparsly
Copy link
Collaborator

@nparsly nparsly commented Jul 7, 2023

Finished the developer documentation

@zmalkmus
Copy link
Collaborator

zmalkmus commented Aug 2, 2023

The documentation looks good. I added an update to the section mentioning the http.server to include the new Flask backend instead.

@zmalkmus zmalkmus self-requested a review August 2, 2023 18:06
zmalkmus
zmalkmus previously approved these changes Aug 2, 2023
@zmalkmus zmalkmus dismissed their stale review August 2, 2023 18:09

Includes code from another PR

Belongs in filereader pull request
Added Flask update to patch notes
Belongs in filereader PR
Changes belong in filereader PR
Changes belong in filereader PR
Changes belong in filereader PR
Copy link
Collaborator

@zmalkmus zmalkmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed files from the csv reader pull request. Updated some documentation to be consistent with the latest AGVis changes. Otherwise the documentation looks good.

@zmalkmus zmalkmus merged commit d684c11 into master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants