Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescrapes dialect data after #548 #551

Merged
merged 15 commits into from
Jul 17, 2024
Merged

Conversation

kylebgorman
Copy link
Collaborator

@kylebgorman kylebgorman commented Jul 17, 2024

  • Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

#548 fixed bug in the dialect selector. In this PR we re-scrape data for languages with dialect specification: ben, cym, eng, hye, por, spa, vie. This requires phonelist fixes for hye, por, spa, and vie (mostly in favor of greater consistency), and in the latter, the Hoi Chi Min dialect is now called "Saigon" here. In vie we also have to roll out the basic change from #548 into the custom selector.

@kylebgorman kylebgorman marked this pull request as ready for review July 17, 2024 12:34
@kylebgorman kylebgorman mentioned this pull request Jul 17, 2024
1 task
@kylebgorman kylebgorman merged commit f1ed683 into CUNY-CL:master Jul 17, 2024
10 checks passed
@kylebgorman kylebgorman deleted the dialect branch July 17, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant