-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added geminate consonants to Norwegian Bokmal phonelist #542
Conversation
The change to the phonelist itself looks good. Please follow steps 4-7 here and the tests you see above ought to pass. I am assuming that segments like /h/ are excluded on the grounds they are (never?) geminates in this language. |
That’s right, I only considered consonants for which I found evidence, either online or in the data itself, that they can be geminates. /h/ was not one of these. Unfortunately, there wasn't a lot of detailed information online. Many sources simply mentioned the possibility of "long consonants” and their relationship to short vowels. |
That’s fine, proceed with that. |
… phoneme /ʊ/ for Norwegian Bokmal
data/scrape/lib/unscraped.json
Outdated
@@ -0,0 1,4 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run git checkout -- unscraped.json
(in this directory, or use the full path from another directory). This doesn't need checked in.
data/scrape/lib/languages.json
Outdated
@@ -460,7 460,8 @@ | |||
"latn": "Latin", | |||
"hira": "Hiragana", | |||
"bopo": "Bopomofo", | |||
"hani": "Han" | |||
"hani": "Han", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run git checkout -- languages.json
(in this directory, etc.) on this file. It doesn't need checked in or modified here, even if the procedures caused it to be. (I think that's a very minor bug for us to fix separately.)
Reverting those two files (as suggested above) and then rerunning |
I realize I mispoke. I think that |
Restore didn’t seem to do anything, but I was able to remove the two files from the PR by reverting the files to the commit before I made the changes using |
There is now a different, later error that the tests are failing on, but it's one completely unrelated to what you did so I give you a dispensation to submit; I'll resolve that issue separately. Let me know if you're ready for me to merge. |
Yep, ready! |
Before I merge this I'm going to edit your PR description to include the string "Closes #532". This tells GitHub that the PR, once merged, should be linked with that issue, and should mark it as closed. |
Added long consonants Norwegian Bokmal (nob) phonelist, as they were missing.
Closes #532