Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English scrape after #511 #515

Merged
merged 2 commits into from
Feb 7, 2024
Merged

English scrape after #511 #515

merged 2 commits into from
Feb 7, 2024

Conversation

kylebgorman
Copy link
Collaborator

@kylebgorman kylebgorman commented Feb 7, 2024

Note that the sizes are slightly smaller (at least in some cases) because dialect selectors were not working on previous scrapes.

A subsequent PR will include all other languages except Latin (see #514).

  • Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

Note that the sizes are slightly smaller (at least in some cases)
because dialect selectors were not working on previous scrapes.

A subsequent PR will include all other languages except Latin (see
@kylebgorman
Copy link
Collaborator Author

The tests are failing on Latin (see #514) as expected, but otherwise green. If there's no objection I'll merge this shortly.

@kylebgorman kylebgorman changed the title Adds first English scrape since #511. English scrape since #511 Feb 7, 2024
@kylebgorman kylebgorman changed the title English scrape since #511 English scrape after #511 Feb 7, 2024
@kylebgorman kylebgorman merged commit bad2358 into CUNY-CL:master Feb 7, 2024
4 of 9 checks passed
@kylebgorman kylebgorman deleted the eng branch February 21, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant