Add support for multiple attr for select input type #1312
Conversation
There was a problem hiding this comment.
- There are some code-formatting issues.
CMB2_Utils::normalize_if_numeric( $opt_value )should be used where you're using just$opt_value.in_arrayshould have the strict mode set, by setting 3rd param totrue- Last else-if is a repeat of the first if?
- Provide testing instructions please.
This can be tested against a select field with attr "multiple": $cmb->add_field( array( 'name' => 'Test Select', 'id' => 'wiki_test_select', 'type' => 'select', 'options' => array( 'standard' => __( 'Option One', 'cmb2' ), 'custom' => __( 'Option Two', 'cmb2' ), 'none' => __( 'Option Three', 'cmb2' ), ), 'attributes' => array( 'multiple' => true ), ) );
|
@jtsternberg This can be tested against a select field with the attribute "multiple": By using the attribute multiple this will submit multiple values in the same meta. This code recognizes that the value is an array and acts accordingly to save the data correctly. This is what I remember I did to fix the issue that I faced with a select with multiple values. I've fixed the code following your comments 👍 |
Props to @rubengc #995
Didn't found this in a PR format so created this one.
Please advise.
Description
Add support for attribute multiple, showing correctly the multiple elements saved on database
Motivation and Context
Motivation to provide CMB2 with the multiple feature out of box easily.
Fixes #995
Risk Level
admin-only
Testing procedure
You can test by adding the 'multiple' attribute to a select field type
$cmb->add_field( array( 'name' => 'Test Select', 'id' => 'wiki_test_select', 'type' => 'select', 'options' => array( 'standard' => __( 'Option One', 'cmb2' ), 'custom' => __( 'Option Two', 'cmb2' ), 'none' => __( 'Option Three', 'cmb2' ), ), 'attributes' => array( 'multiple' => true ) ) );Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: