[Fixes #1250] Support custom groups with unique or without ids #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipemat
added a commit
to lipemat/CMB2
that referenced
this pull request
Apr 10, 2019
* fix/1250: [Updates CMB2#1252] Use existing classes when adding a new row to group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1250
This code accounts for 2 common scenarios when using
render_row_cbto customize the markup used in groups. Currently, unless the rows include and follow the plugins's pattern exactly for ids, JS issues occur.Scenarios this accounts for.
Bonus