System info #98
Merged
System info #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gging. Refactored code for getting screen resolution to remove deprecations.
…se parameters are needed
tab-cmd
approved these changes
Oct 18, 2020
| ------- | ||
| (width, height) | ||
| """ | ||
| screen = pyglet.canvas.get_display().get_default_screen() |
There was a problem hiding this comment.
This will need to change slightly to work with the updated dependencies
|
|
||
| mem = psutil.virtual_memory() | ||
| def get_system_info() -> dict: |
There was a problem hiding this comment.
Awesome - this is exactly what Barry et al. asked for!
| 'platform-version': platform.version(), | ||
| 'architecture': platform.machine(), | ||
| 'processor': platform.processor(), | ||
| 'cpu_count': os.cpu_count(), |
There was a problem hiding this comment.
It looks like we can get the CPU name in most cases. It would be worth adding! https://github.com/workhorsy/py-cpuinfo#raw-fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code spike to log more detailed system information.
Ticket
https://www.pivotaltracker.com/story/show/175193913
Contributions
Test