Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch rc3 #284

Merged
merged 3 commits into from
May 2, 2023
Merged

Patch rc3 #284

merged 3 commits into from
May 2, 2023

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Apr 29, 2023

Overview

Updated install to allow bcipy app functions to work outside of local development. Currently, many submodules do work as expected and can be used in other packages as a requirement. However, due to missing assets and inits others will fail to work. This PR addresses these small changes and adds greater clarity when using it as a standalone package outside of root.

@tab-cmd tab-cmd requested review from lawhead and celikbasak May 1, 2023 17:07
lawhead
lawhead previously approved these changes May 1, 2023
Copy link
Collaborator

@lawhead lawhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bcipy/main.py Show resolved Hide resolved
Copy link
Member

@celikbasak celikbasak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lawhead lawhead self-requested a review May 2, 2023 19:01
@tab-cmd tab-cmd merged commit 02591eb into main May 2, 2023
@tab-cmd tab-cmd deleted the patch_rc3 branch May 2, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants