Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Phrase task max selections #175

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Copy Phrase task max selections #175

merged 1 commit into from
Oct 12, 2021

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Oct 7, 2021

Overview

Added a parameter to configure the maximum number of selections allowed in a Copy Phrase session.

Ticket

https://www.pivotaltracker.com/story/show/179844380

Contributions

  • Added parameter to configure max_selections
  • Added logic to Copy Phrase task to check the max_selections in the stoppage criteria
  • Code cleanup; mypy fixes

Test

  • Set the max_selections parameter to a low number. Take the Copy Phrase task (with or without the inquiry preview). After the given number of selections the task should exit.

@lawhead lawhead requested a review from tab-cmd October 7, 2021 22:47
@lawhead lawhead merged commit 4a87e8f into 1.5.1 Oct 12, 2021
@tab-cmd tab-cmd deleted the max-series-per-session branch January 24, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tab-cmd tab-cmd tab-cmd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawhead @tab-cmd