Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyQt file dialog #168

Merged
merged 6 commits into from
Sep 2, 2021
Merged

PyQt file dialog #168

merged 6 commits into from
Sep 2, 2021

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Aug 30, 2021

Overview

Replaced Tk dialog instances with an alternative GUI that uses PyQt Widgets.

Ticket

https://www.pivotaltracker.com/story/show/176100240

Contributions

  • Created a new stand-alone widget to encapsulate the PyQt file dialog widgets while providing the simplicity of the interface provided by Tk.
  • Replaced the existing calls to Tk dialogs with the new PyQt version.

Test

  • Tested existing uses of file dialogs and directory prompts, including offline_analysis and Copy Phrase task to ensure that the user is prompted for the correct file type and the computation continues after a file or directory is chosen.
  • Ensured that all unit tests ran successfully.

@lawhead lawhead requested a review from tab-cmd August 30, 2021 22:47
tab-cmd
tab-cmd approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@tab-cmd tab-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so nice! 😭 The failing ubuntu builds can be fixed by pulling or rebasing from the release branch. I don't see any issue merging as is though, I tested it locally. Thanks!

@lawhead lawhead merged commit 11febd2 into 1.5.1 Sep 2, 2021
@tab-cmd tab-cmd deleted the file-dialog branch January 24, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tab-cmd tab-cmd tab-cmd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawhead @tab-cmd