Add experiment-field ui #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawhead
reviewed
Dec 15, 2020
| @@ -142,7 142,7 @@ def init_help(self, font_size: int, color: str) -> QWidget: | |||
| """Initialize the help text widget.""" | |||
| if self.help_tip and self.label != self.help_tip: | |||
| return static_text_control(None, | |||
| label=self.label, | |||
| label=self.help_tip, | |||
There was a problem hiding this comment.
Thanks for fixing this. I noticed this locally and was going to add it to my next PR.
lawhead
reviewed
Dec 15, 2020
| @@ -0,0 1,43 @@ | |||
|
|
|||
There was a problem hiding this comment.
These custom exceptions are nice.
lawhead
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added an experiment field collection widget. Various refactors and cleanup work included. If not mentioned explicity in contributions, it was a linting update
Ticket
https://www.pivotaltracker.com/story/show/176044196
Contributions
Added
Makefile: convenient file to run the various install, testing, and linting commandsExperimentField: gui to collect registered field data by experiment namegui/experiments/demo/demo_experiment_field_collection.py: to demo the experiment field ui. This may not be needed...helpers/exceptions: Field and Experiment specific exceptionsvalidate: validate experiments and field writeUpdated
README.md: with makefile instructionsbci_main: to validate experiments and collect experiment field data. Add better experiment options to help output.gui_main: to use help tip text for the helptipload: added the load_experiment_fields methodsave: add save experiment fieldsession: added a collect_experiment_field_data method to call theExperimentFieldGUIrequirements: add back openpyxl version lockparameters: to include experiment filename for exportpull_request_template: fix spelling / grammar errorsTest
ExperimentField.pyDocumentaion