Add support for basic components in React native #1475
Conversation
🦋 Changeset detectedLatest commit: a21a753 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 8531560 | Triggered | Generic High Entropy Secret | 53feb5d | nx.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a21a753. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
@samijaber This PR is ready for you review now, I have resolved your comments, can you please check it whenever you are free |
|
@samijaber I have resolved the comments now, and separated the logic on two loops like we agreed, sorry if i were late. |
|
@Othman2001 you need to re-run the snapshots one last time for it to fix a merge conflict, and you're good to go! |
Head branch was pushed to by a user without write access
@samijaber Done I have updated the snapshots, This PR is ready to go 🥳 |
Description
Please provide the following information:
What changes have you made:
Support button, touchable opacity, Image and Linking
Why you made them, and:
I think this change is very important to react native generator as it is currently is not supporting all core components.
Any other useful context:
I think using a Button is much more convenient than pressable, that's why I migrated pressable usage to the button.
the fiddle is not working properly with the Image component for some reason, but I managed to run the source code locally and tested all of my changes.
Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
Format the codebase
Update all snapshots