Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Vue SDK SSR A/B Test flicker #3186

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Fix: Vue SDK SSR A/B Test flicker #3186

merged 3 commits into from
Apr 10, 2024

Conversation

samijaber
Copy link
Contributor

@samijaber samijaber commented Apr 10, 2024 •
edited
Loading

Description

Vue SDK: remove flicker by no longer unmounting unselected variants.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: cbcc084

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@builder.io/sdk-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-pages-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 7:13pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
nextjs-app-router-example ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 7:13pm
qwik-city-sdk-example ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 7:13pm
svelte-vite-example ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 7:13pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 10, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cbcc084. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 13 targets

Sent with 💌 from NxCloud.

@samijaber samijaber marked this pull request as ready for review April 10, 2024 19:11
@samijaber samijaber requested review from a team as code owners April 10, 2024 19:11
@samijaber samijaber requested review from mrkoreye and removed request for a team April 10, 2024 19:11
@samijaber samijaber merged commit 6aa7dd0 into BuilderIO:main Apr 10, 2024
16 of 20 checks passed
@samijaber samijaber deleted the fix/vue-ssr-ab-test branch April 10, 2024 19:11
@samijaber samijaber mentioned this pull request Apr 11, 2024
Merged
samijaber added a commit that referenced this pull request Apr 11, 2024
@samijaber
Vue2 LTS: fix SSR flicker (#3192)
f90e76d 
## Description

Backported:

- #3186 (was causing issues in A/B tests)
- #3064 (might be causing issues in non A/B tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkoreye mrkoreye Awaiting requested review from mrkoreye mrkoreye is a code owner automatically assigned from BuilderIO/sdks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samijaber