Implemented UID System for Rules #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UID Rule IDs and Nurikabe IDs
Assign Masyu IDs
Assigned HeyAwake IDs
UID Assign IDs
Added Rule IDs
Renamed the rule to "Unreachables are Black"
Prototype getRuleByID()
Modified all the generic constructors so they accept a ruleID parameter
Added all the IDs from shorttruthtable_reference_sheet.txt for elimination rules
Added all the rule IDs for introduction rules from shorttruthtable_reference_sheet.txt
Added all the IDs for case rules from shorttruthtable_reference_sheet.txt
Added rule IDs for contradiction rules from shorttruthtable_reference_sheet.txt
…s-not-working Fixed Short Truth Table IDs
Added changes for UID consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave each rule a unique ID. This means now that identification of rules no longer relies on the name of the rule, and so rules can be freely renamed. Note that this update will also break backwards compatibility with any puzzle files that contained proofs, but not raw puzzle files.
Note that
dev-uid_resolve-conflictsresolves all the conflicts betweendevanduid.