Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish room case rule attempt #788

Merged
merged 33 commits into from
Apr 2, 2024

Conversation

cadogs
Copy link
Collaborator

@cadogs cadogs commented Apr 2, 2024

Description

Generates different ways to finish a room

Closes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

cadogs and others added 30 commits October 20, 2023 16:59
…s no case rules that alter 2 separate puzzzle tiles I added the basis for those in the case rule class
Remove unecessary changes from caseRule.java. Show all work before deleting uneccesary bits from finishRoom case rule attempt.
First clean attempt at rule.
need help
Rooms seem to be finished correctly including all edge cases. Arrow color is still red but may be fixed when updating my branch.
Removed print statements and unnecessary lines
Green arrows now show when rule is ran correctly. Red arrow when incorrect and larger than 5 paths. Started the test case for it.
Work on test class and start of work within Rule and CaseRule to correctly display error message when too many cases are generated
Max cases is generalized for each case rule. Can be altered from the original 10 to whichever you choose. I input 5 for finish room and 2 for black or white case rule in Nurikabe but can be done for case rules in other puzzles. AutoCaseRuleCommand was changed as well to display message when too many cases of the case rule is generated.
Created and added new image to display the finish room case rule
Initial passing cases, may need additional work but currently passes.
Fixes green arrow when using case rule after altering 1 random tile. Also sets minimum cases number to 2.
cadogs and others added 2 commits April 2, 2024 16:22
fixes bug where correct cases would be generated and the user would delete one of the cases and the arrows would still show as green being a logical move.
@charlestian23 charlestian23 merged commit ef00322 into Bram-Hub:dev Apr 2, 2024
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants