LEGUP 6.0.1 Push #776
Merged
LEGUP 6.0.1 Push #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed all Inno Setup related code
Co-authored-by: Chase Grajeda <76405306 [email protected]> Co-authored-by: Charles Tian <46334090 [email protected]>
Added GridRegion class template. Soft release, should not be used by clients
The test case seems to run even without adding it to this file.
10 tasks
* Attempting improvements * Added git config info * Added check for modified files * Modifying GitHub Token use * Temporarily changing user for my fork * Change fork checking and repo name retrieval * Changing back Testing these changes on my fork now doesn't work * Removed distribution * Didn't properly change back * More testing * Testing to see if this works...? * Update java-autoformat.yml * Set upstream * Changing back to Bram * Changing method to create pull request * Modifying job execution conditions * Automated Java code formatting changes * Update java-autoformat.yml Changed branch name to be unique and fail task on master PRs * More debugging * More debugging * More changes * Adding bad formatting for testing * Automated Java code formatting changes * Even more debugging * Bug fixing * EVEN MORE DEBUGGING * Debugging... * Update java-autoformat.yml * Update java-autoformat.yml * Update java-autoformat.yml * Update java-autoformat.yml * Update java-autoformat.yml * Update java-autoformat.yml * Update java-autoformat.yml * Update java-autoformat.yml * Bad formatting for testing * Update java-autoformat.yml * Update java-autoformat.yml * Automated Java code formatting changes * Update java-autoformat.yml * DEBUG * Trying different way to check for modified files * Bad formatting for testing * Automated Java code formatting changes * More changes more testing * Automated Java code formatting changes --------- Co-authored-by: Bram van Heuveln <[email protected]>
* Created Or Contradiction test files * Added false or test * Fixed false or test and added unknown or test * Methods should start with lowercase * Added true or test and removed useless lines * Added Not Contradiction test * Remove useless print statement * Added And Contradiction tests * Removed useless imports * Fixed bug with test * Added conditional test cases * Create ConditionalContradictionRuleTest.java Added Conditional Contradiction Rule tests * Added biconditional test files * Fixed typo * Create BiconditionalContradictionRuleTest.java Added biconditional contradiction rule tests * Added single test file * Added remaining test files * Added JUnit test * Removed unused tests Removed deprecated importer and statement tests --------- Co-authored-by: Chase Grajeda <76405306 [email protected]> Co-authored-by: Chase-Grajeda <[email protected]>
* Created conditional case rule test files * More test files * Created Conditional Case Rule tests * Added test files * Started creating tests Added true biconditional tests, false biconditional tests are not written yet * Finished False tests and changed variable names * Update BiconditionalCaseRuleTest.java Modified comments * Update OrCaseRuleTest.java Fixed inaccurate comments --------- Co-authored-by: Chase Grajeda <76405306 [email protected]>
* Automated Java code formatting changes * Automated Java code formatting changes --------- Co-authored-by: Bram van Heuveln <[email protected]> Co-authored-by: Charles Tian <46334090 [email protected]>
[LightUp] Added FinishWithEmptyDirectRule test cases
Co-authored-by: Bram van Heuveln <[email protected]>
* Update SurroundRegionDirectRule.java * Update SurroundRegionDirectRule.java * Update SurroundRegionDirectRule.java * Create FinishRoomCaseRule.java * more work done to finish room case rule. Also since there currently is no case rules that alter 2 separate puzzzle tiles I added the basis for those in the case rule class * Finish Room Case rule work Remove unecessary changes from caseRule.java. Show all work before deleting uneccesary bits from finishRoom case rule attempt. * FinishRoomCaseRule initial completed attempt First clean attempt at rule. * get draft pull need help * Changed the ID * Update FinishRoomCaseRule.java * Finish Room Case Rule Basically Done Rooms seem to be finished correctly including all edge cases. Arrow color is still red but may be fixed when updating my branch. * Cleaned up code Removed print statements and unnecessary lines * Finish Room green arrows and test case start Green arrows now show when rule is ran correctly. Red arrow when incorrect and larger than 5 paths. Started the test case for it. * Tests and rule rework Work on test class and start of work within Rule and CaseRule to correctly display error message when too many cases are generated * Generalized max cases Max cases is generalized for each case rule. Can be altered from the original 10 to whichever you choose. I input 5 for finish room and 2 for black or white case rule in Nurikabe but can be done for case rules in other puzzles. AutoCaseRuleCommand was changed as well to display message when too many cases of the case rule is generated. * FinishRoom Image Created and added new image to display the finish room case rule * Added argument for minimum number of case rules * Test Case initial Initial passing cases, may need additional work but currently passes. * Update CaseRule.java * False justification bug fix Fixes green arrow when using case rule after altering 1 random tile. Also sets minimum cases number to 2. --------- Co-authored-by: Ivan Ho <41582274 [email protected]> Co-authored-by: Charles Tian <46334090 [email protected]> Co-authored-by: charlestian23 <[email protected]>
Co-authored-by: Bram van Heuveln <[email protected]>
* Update SurroundRegionDirectRule.java * Update SurroundRegionDirectRule.java * Update SurroundRegionDirectRule.java * Create FinishRoomCaseRule.java * more work done to finish room case rule. Also since there currently is no case rules that alter 2 separate puzzzle tiles I added the basis for those in the case rule class * Finish Room Case rule work Remove unecessary changes from caseRule.java. Show all work before deleting uneccesary bits from finishRoom case rule attempt. * FinishRoomCaseRule initial completed attempt First clean attempt at rule. * get draft pull need help * Changed the ID * Update FinishRoomCaseRule.java * Finish Room Case Rule Basically Done Rooms seem to be finished correctly including all edge cases. Arrow color is still red but may be fixed when updating my branch. * Cleaned up code Removed print statements and unnecessary lines * Finish Room green arrows and test case start Green arrows now show when rule is ran correctly. Red arrow when incorrect and larger than 5 paths. Started the test case for it. * Tests and rule rework Work on test class and start of work within Rule and CaseRule to correctly display error message when too many cases are generated * Generalized max cases Max cases is generalized for each case rule. Can be altered from the original 10 to whichever you choose. I input 5 for finish room and 2 for black or white case rule in Nurikabe but can be done for case rules in other puzzles. AutoCaseRuleCommand was changed as well to display message when too many cases of the case rule is generated. * FinishRoom Image Created and added new image to display the finish room case rule * Added argument for minimum number of case rules * Test Case initial Initial passing cases, may need additional work but currently passes. * Update CaseRule.java * False justification bug fix Fixes green arrow when using case rule after altering 1 random tile. Also sets minimum cases number to 2. * deleting cases fix fixes bug where correct cases would be generated and the user would delete one of the cases and the arrows would still show as green being a logical move. --------- Co-authored-by: Ivan Ho <41582274 [email protected]> Co-authored-by: Charles Tian <46334090 [email protected]> Co-authored-by: charlestian23 <[email protected]>
Co-authored-by: Bram van Heuveln <[email protected]>
Chase-Grajeda
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing updates from March to
master: