Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishing Short Truth Table Contradiction Rule tests #713

Merged
merged 22 commits into from
Mar 29, 2024

Conversation

charlestian23
Copy link
Collaborator

@charlestian23 charlestian23 commented Jan 31, 2024

Description

This pull request adds tests for the remaining contradiction rules in Short Truth Table.

Closes #652, #653, #654 , #655, #656, #657

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@charlestian23 charlestian23 marked this pull request as draft January 31, 2024 20:25
@charlestian23 charlestian23 marked this pull request as ready for review February 13, 2024 22:26
@charlestian23 charlestian23 requested a review from Bram28 February 13, 2024 22:26
@charlestian23 charlestian23 changed the title Finishing Short Truth Table tests Finishing Short Truth Table Contradiction Rule tests Feb 13, 2024
@Chase-Grajeda
Copy link
Collaborator

@Bram28 Could you review the test logic? Will be merged next week

Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run correctly

Removed deprecated importer and statement tests
@Chase-Grajeda Chase-Grajeda merged commit 5452703 into Bram-Hub:dev Mar 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants