Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save File Path #562

Merged
merged 7 commits into from
Jun 23, 2023
Merged

Save File Path #562

merged 7 commits into from
Jun 23, 2023

Conversation

04vmatsibekker
Copy link
Collaborator

@04vmatsibekker 04vmatsibekker commented Jun 23, 2023 •
edited
Loading

Description

Once someone has opened a puzzle, a variable stores the current file path, then when the user attempts to open another puzzle the user is directed to that same file path

Closes #548

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

charlestian23 and others added 6 commits May 5, 2023 14:23
@charlestian23
Merge pull request #523 from Bram-Hub/dev
f81475f 
Spring 2023 Semester Pull Request
@04vmatsibekker
Get Tests to be called
ef12e8f 
Revert "Create first cypress test template"

This reverts commit 3e50909.

First commit

Finish Lightup tests
@04vmatsibekker
Add more tests
5673e02 
Update TestRunner.java
@04vmatsibekker
Somehow ended up in the wrong spot
3445e36 
Fix Import
@Bram28
Merge pull request #558 from Bram-Hub/Test-runner
8fb5750 
Get Tests to be called
@04vmatsibekker
Update ProofEditorPanel.java
886ea3d 
hi

Update ProofEditorPanel.java
@04vmatsibekker 04vmatsibekker changed the title Filepaths Save file path Jun 23, 2023
@04vmatsibekker 04vmatsibekker changed the title Save file path Save File Path Jun 23, 2023
@04vmatsibekker 04vmatsibekker changed the base branch from master to dev June 23, 2023 21:05
Bram28
Bram28 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@Bram28 Bram28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!!

@Bram28 Bram28 merged commit f6418b6 into dev Jun 23, 2023
@hansongu123 hansongu123 mentioned this pull request Jun 30, 2023
Closed
@hansongu123 hansongu123 deleted the file-path branch June 30, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bram28 Bram28 Bram28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Keep file path in history
3 participants
@04vmatsibekker @Bram28 @charlestian23