Spring 2023 Semester Pull Request #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed UI texts, file and function names that have "Basic Rules" in it to "Direct Rules."
…term "Direct Rules" instead of "Basic Rules"
Fixed: Rename "Basic Rules" to "Direct Rules"
Cancel `Solve Puzzle`
Testing Flatlaf On Dev
[FIXED BUG] <Editing a Puzzle's that don't have an edit funciton>
* Update NurikabeCell.java Changed setType() to use element IDs rather than element names * Renamed instances of Basic Rule to Direct Rule * Renamed Basic Rule to Direct Rule for Tree Tent tests * Renamed directories from Basic Rule to Direct Rules * Renamed Direct Rules to Basic Rules in Light Up tests * Added back BlockInVerticalPath
* Update Config.java * Update GameBoardFacade.java * Update ICommand.java * Update ICommand.java * Update ICommand.java * Update Puzzle.java * Update GameBoardFacade.java * Update Config.java * Update GameBoardFacade.java * Update Puzzle.java * Update Puzzle.java * Update Puzzle.java * Update SkyscrapersBoard.java * Update SkyscrapersBoard.java * Update SkyscrapersBoard.java * Update SkyscrapersBoard.java * Update SkyscrapersBoard.java * Update SkyscrapersBoard.java * Update SkyscrapersBoard.java * Update SkyscrapersCellFactory.java * Update PuzzleExporter.java * Update BattleshipCellFactory.java * Update PuzzleExporter.java * Update PuzzleImporter.java * Update PuzzleImporter.java * Update PuzzleImporter.java * Update PuzzleImporter.java * Update PuzzleImporter.java * Update PuzzleImporter.java * Update PuzzleImporter.java * Update PuzzleImporter.java * Update PuzzleImporter.java * Update BattleshipImporter.java * Created descriptions for param node and exception InvalidFileException * Update BattleshipType.java * Update BattleshipType.java * Update BoardView.java * Update GridBoardView.java * Update FillapixCellFactory.java * Update FillapixImporter.java * Update FillapixImporter.java * Update HeyawakeFactory.java * Update HeyawakeImporter.java * Update BattleshipImporter.java * Update HeyawakeImporter.java * Update AutoCaseRuleCommand.java * Update AutoCaseRuleCommand.java * Update ValidateCaseRuleCommand.java * Update LightUpCellFactory.java * Update LightUpImporter.java * Update MasyuCellFactory.java * Update MasyuImporter.java * Update NurikabeCellFactory.java * Update NurikabeImporter.java * Update RulePanel.java * Update RulePanel.java * Update RulePanel.java * Update RulePanel.java * Update RulePanel.java * Update ShortTruthTableCellFactory.java * Update ShortTruthTableCellType.java * Update ShortTruthTableCellType.java * Update ShortTruthTableCellType.java * Update SkyscrapersBoard.java * Update SkyscrapersImporter.java * Update SkyscrapersImporter.java * Update SudokuCell.java * Update SudokuCellFactory.java * Update SudokuImporter.java * Update SudokuImporter.java * Update Tree.java * Update TreeTentCellFactory.java * Update TreeTentImporter.java * Update TreeToolbarPanel.java * Update LegupUI.java * Update WrapLayout.java * Update LegupUtils.java * Update ValidateContradictionRuleCommand.java --------- Co-authored-by: Ivan Ho <41582274 [email protected]> Co-authored-by: Charles Tian <46334090 [email protected]>
* Reset button attempt 1 * Reset button attempt works * checkstyle fix * checkstyle fix * checkstyle fix --------- Co-authored-by: Charles Tian <46334090 [email protected]> Co-authored-by: Ivan Ho <41582274 [email protected]>
Update NurikabeCell.java to use .getElementID instead of .getElementName
Changed NurikabeCell.java from if/else to switch statements
510 nurikabe tests
Allowed Case rules for Light Up puzzles to Have Only One Option
Chase-Grajeda
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A pull request containing the work from the Spring 2023 semester. Majority of the work done this semester was bug fixes.
Note: Short Truth Table puzzle editor support will be delayed to the next pull request due to issues with getting the files to save properly