Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tests for BulbsInPath, CannotLightACell, TooFewBulbs, and TooManyBulbs Contradiction Rules #506

Merged
merged 21 commits into from
Apr 7, 2023
Merged

Added Tests for BulbsInPath, CannotLightACell, TooFewBulbs, and TooManyBulbs Contradiction Rules #506

merged 21 commits into from
Apr 7, 2023

Conversation

Acewvrs
Copy link
Collaborator

@Acewvrs Acewvrs commented Mar 24, 2023 •
edited
Loading

Description

I added a few unit tests that ensure BulbsInPath, CannotLightACell, and TooFewBulbs contradiction rules work in various cases.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@charlestian23 charlestian23 self-requested a review March 28, 2023 14:38
@charlestian23 charlestian23 self-assigned this Mar 28, 2023
@Acewvrs
Copy link
Collaborator Author

Acewvrs commented Mar 28, 2023

currently it is not passing all the checks because the test files aren't in the parent repo

@Acewvrs Acewvrs changed the title Added Tests for BulbsInPath, CannotLightACell, and TooFewBulbs Contradiction Rules Added Tests for BulbsInPath, CannotLightACell, TooFewBulbs, and TooManyBulbs Contradiction Rules Mar 28, 2023
Acewvrs and others added 19 commits April 4, 2023 16:39
@Acewvrs @Corppet
set test points to make sure the STT files are loaded in correctly
5cfd31e
@Acewvrs @Corppet
testing transitions
5fbbb9b
@Acewvrs @Corppet
added a test case, BlockInVerticalPath for LightUp that tests there i…
29d07e0 
…sn't a contradiction if there is a block between two bulbs.
@Acewvrs @Corppet
added a test case, CannontFillMiddle for LightUp that tests CannotLig…
e44d79b 
…htACell Contradiction Rule
@Acewvrs @Corppet
removed unnecessary indent
8c22d2e
@Acewvrs @Corppet
Added unit tests tor CannotLightACellContradictionRuleTest and TooFew…
16e64dd 
…BulbsContradictionRuleTest.
@Acewvrs @Corppet
Added test LightUp files for testing
aed3c7a
@Acewvrs @Corppet
removed an unnecessary comment and spacing
15dbee6
@Acewvrs @Corppet
Added another set of tests for TooManyBulbsContradictionRule
3ec5ea8
@Acewvrs @Corppet
Added Randomly Generated 7x7 lightup puzzles
675088f
@Corppet
Remove extra spaces in JavaDocs
ff9333b
@Corppet
Removed extra spaces from JavaDocs
d79ce0a
@Corppet
Update FinishWithEmptyDirectRule.java
88b197d
@Corppet
revert
b6046c8
@Corppet
Reverted JavaDocs
12e3bcd
@Corppet
Revert JavaDocs
8812087
@Acewvrs
Merge branch 'dev' into dev
a322c3c
@Acewvrs
Merge branch 'dev' into dev
3bf57f8
@charlestian23
Merge branch 'dev' into dev
d5d8ee5
@charlestian23 charlestian23 requested review from Corppet and removed request for charlestian23 April 7, 2023 14:37
charlestian23
charlestian23 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be good, I'll open an issue if the tests don't pass even once they're merged into dev.

@charlestian23 charlestian23 merged commit c79372c into Bram-Hub:dev Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlestian23 charlestian23 charlestian23 approved these changes

@Corppet Corppet Awaiting requested review from Corppet

Assignees

@charlestian23 charlestian23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Acewvrs @charlestian23 @Corppet