Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PuzzleEditorPanel.java #484

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

walkingjason
Copy link
Collaborator

Description

To keep the consistency between PuzzleEditorPanel and ProofEditorPanel. The onClearHistory() function for the former is implemented. Both functions could be called from the clear() function from the History class. However, at this point, the onClearHistory() function in the PuzzleEditorPanel class is not being used anywhere. This commit is made for future development.

Closes #479

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

This function is not used, and it is not tested.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@walkingjason
Copy link
Collaborator Author

walkingjason commented Feb 28, 2023

@Mbijur Is this what the original Issue expected?

@Mbijur
Copy link
Collaborator

Mbijur commented Mar 3, 2023

yes

@walkingjason walkingjason marked this pull request as ready for review March 17, 2023 14:45
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine

@charlestian23 charlestian23 merged commit f2c6d57 into Bram-Hub:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear History is not Implemented in the PuzzleEditor Panel
3 participants