Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Add dark mode #404 #466

Merged
merged 2 commits into from
Feb 24, 2023
Merged

[ENHANCEMENT] Add dark mode #404 #466

merged 2 commits into from
Feb 24, 2023

Conversation

kevinkxu
Copy link
Collaborator

@kevinkxu kevinkxu commented Feb 18, 2023 •
edited
Loading

Description

Added a checkbox under general preferences in the preferences menu that toggles night mode on/off. Toggles between FlatLightLaf and FlatDarkLaf.

Closes #404 (#404)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@charlestian23 charlestian23 self-assigned this Feb 20, 2023
charlestian23
charlestian23 approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are mostly good. There are some issues with it, but they are unrelated to the implementation of dark mode. I'll open issues for those separately.

@charlestian23 charlestian23 merged commit 1d0eb94 into Bram-Hub:dev Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlestian23 charlestian23 charlestian23 approved these changes

@Corppet Corppet Awaiting requested review from Corppet

Assignees

@charlestian23 charlestian23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinkxu @charlestian23