Fixes for TreeTent rules not dependent on links #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed EmptyField, LastCampingSpot, and TouchingTents rules
Fixed TouchingTents not accounting for diagonal tents, and made significant progress on FillInRow (although some will need to be redone because I misunderstood the class of the clues)
Implement fill in row, make some fixes for no tree for tent
charlestian23
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for EmptyField, LastCampingSpot, TouchingTents, NoTreeForTent
Implementation for FillInRow
Specifically:
TouchingTents didn't account for diagonal tents, and would return valid when it shouldn't due to using TreeTentType.TREE instead of TreeTentType.TENT
LastCampingSpot didn't actually recognize that a remaining spot was the last camping spot (current implementation doesn't take links into account at all, this is something that will still need to be added)
EmptyField would return valid for any placement of grass, not just grass with no trees adjacent
NoTreeForTent didn't consider linked trees taken, and considered unknown tiles possible trees
FillInRow had no implementation, now it has one, although the edge tiles that should be clicked to select what row the user wants to fill in has no highlighting yet