Fix: "Uncaught TypeError: Cannot read property 'className' of null" #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll" bug that appears when creating folders
asmsuechan
reviewed
Oct 13, 2017
browser/main/index.js
Outdated
| let isInfoPanel = false | ||
| if (e.target.offsetParent !== null) { | ||
| isInfoPanel = e.target.offsetParent.className.includes('infoPanel') | ||
| } |
There was a problem hiding this comment.
Cool! However, I prefer this way
const offsetParent = e.target.offsetParent
const isInfoPanel = offsetParent !== null
? offsetParent.className.includes('infoPanel')
: falseHow about this?
There was a problem hiding this comment.
Sure. I will update that in a bit. The only reason I did it the way I did is for readability. Ternary statement it is!
…ll" bug that appears when creating folders (coding style adjustments)
|
Thank you so much! |
|
Thanks @adrichey ! |
|
Anytime! Glad to assist! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where elements without a target offsetParent were throwing uncaught errors when trying to determine if a click event originated from an info panel element or not.