Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[views] update the viz result kibana_url #206

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

vchrombie
Copy link
Contributor

This PR updates the Kibana dashboard URL of the result after prosoul visualization.

Fixes #205.

This commit updates the Kibana dashboard URL of
the result after prosoul visualization.

Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
@vchrombie
Copy link
Contributor Author

vchrombie commented Mar 30, 2020

Hi @dlumbrer

Can you look into this when you are free?

Also, referencing this comment #205 (comment)

You are right, maybe we can develop the next behavior:

  • If the form is not filled with the URL of Kibana, we use the KIBANA_HOST env. But it filled, we use just the kibana_url param of the form.

I guess the kibana_url param is already mandatory. When I don't fill the field and click on Create, it gives a warning "Please fill out this field."
So, I think it is not needed. WDYT?

Let me know if I have to do any changes in the PR.
Thanks. 🙂

@dlumbrer
Copy link
Contributor

LGTM, thanks @vchrombie !

@dlumbrer dlumbrer merged commit 61eb194 into Bitergia:master Mar 31, 2020
@vchrombie vchrombie deleted the fix-205 branch April 8, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kibana dashboard URL doesn't have the port number
2 participants