Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double tap on phones not working properly. #453

Closed
penobit opened this issue Feb 7, 2024 · 3 comments
Closed

Double tap on phones not working properly. #453

penobit opened this issue Feb 7, 2024 · 3 comments

Comments

@penobit
Copy link

penobit commented Feb 7, 2024

Describe the bug
When i double click on the component with PC/laptop, it will zoom in and out perfectly fine. But if i double tap on same component using a mobile phone (or mobile emulator in browser) it will not zoom in and out unless i hold the second tap.

To Reproduce
Steps to reproduce the behavior:

  1. add a component as a child of TransformWrapper and TransformComponent
  2. double tap on it using a phone or browser dev tools mobile emulator

Expected behavior
The component should scale/zoom on double tap (without having to hold the second tap).

Desktop (please complete the following information):

  • OS: Windows 10/11
  • Browser Microsoft Edge
  • Version latest

Smartphone (please complete the following information):

  • Device: iPhone X
  • OS: iOS 16
  • Browser Safari
  • Version latest
@clintjansen
Copy link

Having same issue, double tap (click) is working very buggy on mobile, especially with the new 'toggle' mode.
It seems the animation to zoom is ended prematurely

@Print3M
Copy link

Print3M commented Feb 19, 2024

Exactly the same problem here. I've figured out some hack, just to make it work on mobile at all:

<TransformWrapper doubleClick={{ mode: "reset", animationTime: 1, animationType: "linear" }}>...</TransformWrapper>

animationTime: 1 does the job. I've added animationType: "linear" just in sake of performance maximization.

Pros: it seems pretty stable right now :)
Cons: it doesn't show nice and smooth animation anymore - the transition is instant :(

NOTE: animationTime: 0 seems to work buggy as well. No idea why.

@RobinSCU RobinSCU mentioned this issue Jul 1, 2024
Merged
@RobinSCU
Copy link
Contributor

RobinSCU commented Jul 3, 2024

Hi @penobit, @Print3M and @clintjansen,

@prc5 has released a new version with a merged fix from me. It should fix your problems hopefully :)

@penobit penobit closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clintjansen @RobinSCU @penobit @Print3M