Improvements #6
Merged
Improvements #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my personal callbacks component that I have developed, called property, you subscribe to a data type , a class, everything you want, and you don't care about callbacks management, it's will be done automatically. I tested it on the coins logic and it's working well.
I changed the resumegame from being inside every close screen call to only resume game when closing the pause screen.
|
Great work, thanks for the improvements! keep up the good work! |
hasanbayatme
requested review from
hasanbayatme
and removed request for
hasanbayatme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(As I said, the way callbacks are developed currently is bad because there is no test to unsubscribe from every 'not needed' one, and that cause a lot of problems in transitions and popping up screens when you don't want to. Instead, I have introduced a new way to make things cleaner, Check Scripts/Utils new folder.
I have implemented it in coins only for now, but should be integrated in all our callback calls).