Add "clib\__init__.py" in “python\opencc” #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System description: Windows x64. Python version: 3.9. Running "python setup.py build" results in the following error: ``` copying python\opencc\__init__.py -> build\lib.win-amd64-3.9\opencc package directory 'python\opencc\clib' does not exist. ``` This is because the package 'opencc.clib' is imported in 'python\opencc\__init__.py' (Line 6) before the function "build_libopencc()" in 'setup.py' creates the directory "python\opencc\clib" (Line 83). By adding the file "clib\__init__.py" in the directory “python\opencc”, the command "python setup.py build" can successfully build the files. I do not know whether this is also related to the issue that the wheel files cannot be created on PyPI for Windows for the recent versions (>1.1.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System description: Windows x64. Python version: 3.9.
Running "python setup.py build" results in the following error:
This is because the package 'opencc.clib' is imported in 'python\opencc_init_.py' (Line 6) before the function "build_libopencc()" in 'setup.py' creates the directory "python\opencc\clib" (Line 83).
By adding the file "clib_init_.py" in the directory “python\opencc”, the command "python setup.py build" can successfully build the files.
I do not know whether this is also related to the issue that the wheel files cannot be created on PyPI for Windows for the recent versions (>1.1.1)