Add GenerateCSV and GetMetadataUsage GRPC calls and API #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same comments as on golang version, can you split this into three functions with names similar to the query functions. Also csv writer vs file handle question |
|
@emptyflash this has syntax errors in it!! In future please do not open a pull request if you have not tested the code, or at least make a note. I need to be able to trust that code I am merging is solid. |
|
I'll fix it this time, because I am working here anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added a
requirements.txtand a helper class for dealing with query types. I have a test written up but wasn't sure where to put that here. I think maybe I'll add testing infrastructure in a separate PR though.