Change mainnet address version. #80
Conversation
- Prefix 38 (G) for P2PKH. - Prefix 90 (d) for P2SH.
|
@h4x3rotab any reason to use |
src/chainparams.cpp
Outdated
| base58Prefixes[PUBKEY_ADDRESS] = std::vector<unsigned char>(1,0); | ||
| base58Prefixes[SCRIPT_ADDRESS] = std::vector<unsigned char>(1,5); | ||
| base58Prefixes[PUBKEY_ADDRESS] = std::vector<unsigned char>(1,38); // prefix: G | ||
| base58Prefixes[SCRIPT_ADDRESS] = std::vector<unsigned char>(1,90); // prefix: d |
There was a problem hiding this comment.
Better to use both capital letters
There was a problem hiding this comment.
Actually, as was offered by h4x3rotab, G and g could be used, anyone who has met bitcoin notices that the address is written in different registers, not a big deal if it will be same letter, because users copy-paste them. Many users still didn't understand difference between 1 and 3. Maybe you can consider A (decimal -> 23) as the title referenced to Aurum (gold in periodic table of element).
There was a problem hiding this comment.
Changed to "G" and "A"
Same letter might be a bit confusing. |
Also fixed unit tests.
Usage: `bgold-cli -testnet=false -convertaddress=<address>`
h4x3rotab
changed the title
|
FYI, see simple conversion (and BIP32 wallets) tool: https://github.com/Ayms/bitcoin-wallets#use---convert-bitcoin-addresses |
|
Doubt: So, I have converted my BTC address to a the BTG address format successfully. How about the private key? I tried the same command and it did not work... or that one remains exactly the same? Thanks! |
|
Private key remains the same. |
|
#**** |
| bool operator()(const CNoDestination& no) const { return false; } | ||
| }; | ||
|
|
||
| } // namespace | ||
|
|
||
| bool CBitcoinAddress::Set(const CKeyID& id) | ||
| { | ||
| SetData(Params().Base58Prefix(CChainParams::PUBKEY_ADDRESS), &id, 20); | ||
| return true; | ||
| return Set(id, Params()); |
| bool operator()(const CKeyID& id) const { return addr->Set(id); } | ||
| bool operator()(const CScriptID& id) const { return addr->Set(id); } | ||
| bool operator()(const CKeyID& id) const { return addr->Set(id, params); } | ||
| bool operator()(const CScriptID& id) const { return addr->Set(id, params); } | ||
| bool operator()(const CNoDestination& no) const { return false; } | ||
| }; | ||
|
|
||
| } // namespace | ||
|
|
||
| bool CBitcoinAddress::Set(const CKeyID& id) |
There was a problem hiding this comment.
bool CBitcoinAddress::Set(const CKeyID& id)
bgold-cli -testnet=false -convertaddress=<old-address>Status: