Refactor: server name changes #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MentalNomad
reviewed
Oct 8, 2019
Comment on lines
1477
to
1481
| if (!IsDeprecatedRPCEnabled("addwitnessaddress")) { | ||
| throw JSONRPCError(RPC_METHOD_DEPRECATED, "addwitnessaddress is deprecated and will be fully removed in v0.17. " | ||
| "To use addwitnessaddress in v0.16, restart bitcoind with -deprecatedrpc=addwitnessaddress.\n" | ||
| "To use addwitnessaddress in v0.16, restart bgoldd with -deprecatedrpc=addwitnessaddress.\n" | ||
| "Projects should transition to using the address_type argument of getnewaddress, or option -addresstype=[bech32|p2sh-segwit] instead.\n"); | ||
| } |
There was a problem hiding this comment.
This should probably be revised, given that we're on v0.17 already (BTG skipped at v0.16 release.)
|
Have reviewed & it appears that this commit consists strictly of changes of "bitcoind" to "bgoldd" in text output. (No functional changes.) |
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a remaining of bitcoin core, the code contains reference to bitcoind. This PR rename it as bgoldd.