Agents #83
Merged
Agents #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iknite
approved these changes
Mar 19, 2019
gossip/monitor/monitor.go
Outdated
| monitor.executionTicker = time.NewTicker(conf.TaskExecutionInterval) | ||
| go monitor.runTaskDispatcher() | ||
|
|
||
| return &monitor, nil | ||
| } | ||
|
|
||
| type Task interface { | ||
| Do() | ||
| func (m Monitor) RegisterMetrics(r *prometheus.Registry) { |
There was a problem hiding this comment.
If you're going to change the way we register metrics IMHO, you should change every occurrence of this code, or at least make an Issue, tech debt post-it or whatever to end this task.
There was a problem hiding this comment.
It is changed in all processors.
| } | ||
|
|
||
| func newSnapStore() *snapStore { | ||
| return &snapStore{segments: append([]Segment{}, Segment{})} | ||
| return &snapStore{ | ||
| data: freecache.NewCache(2 << 30), |
There was a problem hiding this comment.
Maybe a small comment of this "magic number"? (why it's 2<<30 at least)
There was a problem hiding this comment.
That's a gigabyte of cache. Its not a magic number. Seems good enough for our testing environment. No other particular reason.
…tes, clean up design, implement out queue as a timedout channel, simplify stop code
…esides in the agent code and not in the processor
…cessors get their cusrtom metrics registered into the agent server
… stop, start and register metrics
…on as they are enqueued
…PI. Sender and qed server share the same metrics server.
suizman
pushed a commit
to jllucas/qed
that referenced
this pull request
Jun 4, 2019
Agents, metrics and some tests refactor Former-commit-id: daa0759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up agents before its transformation.