Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goreleaser: Some adjustments #181

Merged
merged 1 commit into from
Nov 6, 2019
Merged

goreleaser: Some adjustments #181

merged 1 commit into from
Nov 6, 2019

Conversation

tuxillo
Copy link
Contributor

@tuxillo tuxillo commented Oct 23, 2019

  • Rework the Tag detection a bit
  • Exit if build fails
  • Use 'openssl md5' instead of md5sum which is not available in
    some non-Linux systems.

@jllucas jllucas requested a review from suizman October 24, 2019 07:35
iknite
iknite reviewed Oct 24, 2019
View reviewed changes
goreleaser.sh

if [[ $(uname) == "Darwin" ]]
# Assumes anything non-linux has date -u
Osname=$(uname)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do it need the extra variable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. That enables you to do further checks.

suizman
suizman approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@suizman suizman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. We're glad to hear that other people use QED in distinct environments.
LGTM

@tuxillo @suizman
goreleaser: Some adjustments
9be313d 
- Rework the Tag detection a bit
- Exit if build fails
- Use 'openssl md5' instead of md5sum which is not available in
  some non-Linux systems.
@suizman
Copy link
Contributor

suizman commented Nov 6, 2019

Merging

@suizman suizman closed this Nov 6, 2019
@suizman suizman reopened this Nov 6, 2019
@suizman suizman merged commit ff51d82 into BBVA:master Nov 6, 2019
@iknite
Copy link
Contributor

iknite commented Nov 13, 2019

I believe there's a regression in master branch to v0.1

the output of git fetch -ap && git show-tree:

* ff51d824 (master, origin/master) Merge pull request #181 from tuxillo/goreleaser-1
| * f96dd806 (tag: v1.0.0-rc1) Fix Azure release pattern
| * 3c3a3b05 (origin/azure-pipelines-release) Update Azure Pipelines and release script
| * e3223991 (tag: v0.3.0-docs) Merge pull request #146 from jllucas/restore
| * e90d4b33 (tag: v0.2.4-docs) Fix: panic when version is not set in cmd.
| | * 1523582f (origin/dragonboat) WIP
| |/
| | * cf9514b1 (origin/demo) doc: Update README
| |/
| * b3e096e9 (tag: v0.2-alpha) Fix goreleaser environment variables
| | * 8b735da8 (origin/tampering) Update scripts to support MacOS execution
| | * 06127d8f (tag: tampering) update intro documentation
| |/
| * c4ea9d35 (tag: v0.2-M3) Update archive files
| * c44c8b42 (tag: v0.2-M2) Use incremental ports in tests to prevent address already in use
| * c1061353 (tag: v0.2-M1) Remove Mutexes and rename EdSigner to Ed25519Signer
|/
* 32380634 (tag: v0.1) README.md: Update instructions to follow current cli interface, misc fixes
* 4b8cf79a initial push

I believe it needs to be --rebased before merged to master

@iknite
Copy link
Contributor

iknite commented Nov 13, 2019

Something weird is happening to this command diff-ing between commits is OK maybe it's something @panchoh will like to dig into, but it's nothing to be worried. Thanks, guys

@suizman
Copy link
Contributor

suizman commented Nov 13, 2019

Something weird is happening to this command diff-ing between commits is OK maybe it's something @panchoh will like to dig into, but it's nothing to be worried. Thanks, guys

Some time ago we've rewrite the repo history in order to remove binary files. It's possible this causes the inconsistency.
Please open an separate issue to explore this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iknite iknite iknite left review comments

@suizman suizman suizman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuxillo @suizman @iknite