-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goreleaser: Some adjustments #181
Conversation
|
||
if [[ $(uname) == "Darwin" ]] | ||
# Assumes anything non-linux has date -u | ||
Osname=$(uname) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do it need the extra variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea. That enables you to do further checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. We're glad to hear that other people use QED in distinct environments.
LGTM
- Rework the Tag detection a bit - Exit if build fails - Use 'openssl md5' instead of md5sum which is not available in some non-Linux systems.
Merging |
I believe there's a regression in master branch to the output of
I believe it needs to be |
Something weird is happening to this command diff-ing between commits is OK maybe it's something @panchoh will like to dig into, but it's nothing to be worried. Thanks, guys |
Some time ago we've rewrite the repo history in order to remove binary files. It's possible this causes the inconsistency. |
some non-Linux systems.