Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TLS for Raft RPC and GRPC connections #180

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Support TLS for Raft RPC and GRPC connections #180

merged 3 commits into from
Oct 23, 2019

Conversation

aalda
Copy link
Contributor

@aalda aalda commented Oct 23, 2019

Closes #173

@aalda aalda requested a review from gdiazlo October 23, 2019 09:15
@aalda aalda changed the title Support TLS for Raft RCP and GRPC connections Support TLS for Raft RPC and GRPC connections Oct 23, 2019
gdiazlo
gdiazlo approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@gdiazlo gdiazlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TLS configurator approach looks a bit weird, but I don't have an alternative now. Also if we have constructors with a lot of options in the New() I would chose to have a Config option as an argument. But that could be part of other review.

lgtm

@aalda
Copy link
Contributor Author

aalda commented Oct 23, 2019

I agree with all

@aalda aalda merged commit 00f7b1a into BBVA:master Oct 23, 2019
@aalda aalda deleted the raft-tls branch October 23, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdiazlo gdiazlo gdiazlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for TLS in internal cluster communications.
2 participants
@aalda @gdiazlo