fix: minor fix for CI #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
force-pushed
the
fix-ci
branch
2 times, most recently
from
26a3bf7
to
d79679c
Compare
Arvindthiru
reviewed
Aug 14, 2024
| @@ -44,7 44,7 @@ jobs: | |||
|
|
|||
| - name: Set up Ginkgo CLI | |||
| run: | | |||
| go install github.com/onsi/ginkgo/v2/ginkgo@v2.9.5 | |||
| go install github.com/onsi/ginkgo/v2/ginkgo@v2.19.1 | |||
There was a problem hiding this comment.
Any reason why we didn't pick the latest version https://github.com/onsi/ginkgo/releases/tag/v2.20.0?
There was a problem hiding this comment.
too risky, don't want to go to the bleeding edge.
Arvindthiru
reviewed
Aug 15, 2024
|
|
||
| - name: Install Kind | ||
| # Before updating the kind version to use, verify that the current kind image | ||
| # is still supported by the version. | ||
| run: | | ||
| go install sigs.k8s.io/[email protected] |
There was a problem hiding this comment.
The E2E has been skipped, I think this might have a similar effect to bumping kindest node image from 1.28.0 -> 1.29.0 https://github.com/Azure/fleet/actions/runs/10085086350/job/27885114531?pr=890
https://github.com/kubernetes-sigs/kind/releases/tag/v0.22.0
This change might need to be done in conjunction with changes to the fleet-guard-rail
Arvindthiru
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer