fix: address a bug in the IMC resource stats collection process add corresponding unit test #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/controllers/internalmembercluster/v1beta1/member_controller_test.go
Outdated
Show resolved
Hide resolved
pkg/controllers/internalmembercluster/v1beta1/member_controller_test.go
Outdated
Show resolved
Hide resolved
pkg/controllers/internalmembercluster/v1beta1/member_controller_test.go
Outdated
Show resolved
Hide resolved
| corev1.ResourceMemory: resource.MustParse("19Gi"), | ||
| }, | ||
| Available: corev1.ResourceList{ | ||
| corev1.ResourceCPU: resource.Quantity{}, |
There was a problem hiding this comment.
does this mean negative?
There was a problem hiding this comment.
Hi Ryan! This would be the zero value, to cover the case where inconsistency may lead to negative reporting in the available resource section.
ryanzhang-oss
approved these changes
May 23, 2024
britaniar
pushed a commit
to britaniar/fleet
that referenced
this pull request
May 23, 2024
… corresponding unit test (Azure#823)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR addresses a bug in the IMC resource stats collection process. It also adds the unit test for the affected method.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
IMC controller tests are being refactored; more PRs will ensue.