-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{compute-recommender} Remove default --ids from cli parameters #30108
Merged
kairu-ms
merged 1 commit into
Azure:dev
from
joal42:feature/joal/remove-default-ids-arg
Oct 24, 2024
Merged
{compute-recommender} Remove default --ids from cli parameters #30108
kairu-ms
merged 1 commit into
Azure:dev
from
joal42:feature/joal/remove-default-ids-arg
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
compute-recommender spot-placement-recommender | cmd compute-recommender spot-placement-recommender update parameter location : removed property id_part=name |
Thank you for your contribution! We will review the pull request and get back to you soon. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
kairu-ms
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az compute-recommender spot-placement-recommender
Description
In order to resolve the cli user confusion, this pr removes the default --ids from the az compute-recommender spot-placement-recommender cli parameters
Testing Guide
az compute-recommender spot-placement-recommender --help
Now, the help output has no --ids
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.