[Bot Service] az bot directline/email/facebook/kik/msteams/skype/slack/sms/telegram create
: Add --location
argument as specified by user to channel creation for regionality/EUDB
#21908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the location parameter as specified by the user in the
az bot <channel> create
command was not actually used. This was okay previously because all bot resources are global. However due to EU data boundary work, we now support creation of Europe and United States regional bots and guarantee data residency for such bots. Moreover, special test cases for regional bots and regional channels are added. This is not a breaking change.Testing Guide
Newly added test cases:
test_botservice_registration_bot_create_specific_location
test_botservice_create_channel_specific_location
Manually validate existing functionality
az bot create
andaz bot msteams create
without a locationaz bot create -l
andaz bot msteams create -l
with "global", "westeurope" or "westus2" as the specified locationHistory Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.