[Bot Service] az bot directline/email/facebook/kik/msteams/skype/slack/sms/telegram create: Add --location argument as specified by user to channel creation for regionality/EUDB
#21908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nels creation for regionality/EUDB Signed-off-by: jiaxuwu2021 <[email protected]>
Signed-off-by: jiaxuwu2021 <[email protected]>
ghost
added
the
customer-reported
|
Thank you for your contribution jiaxuwu2021! We will review the pull request and get back to you soon. |
ghost
requested review from
jiaxuwu2021
changed the title
az bot directline/email/facebook/kik/msteams/skype/slack/sms/telegram create: Add --location argument as specified by user to channel creation for regionality/EUDB
|
Bot Service |
jayman-dalal
approved these changes
Apr 4, 2022
kairu-ms
approved these changes
Apr 6, 2022
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the location parameter as specified by the user in the
az bot <channel> createcommand was not actually used. This was okay previously because all bot resources are global. However due to EU data boundary work, we now support creation of Europe and United States regional bots and guarantee data residency for such bots. Moreover, special test cases for regional bots and regional channels are added. This is not a breaking change.Testing Guide
Newly added test cases:
test_botservice_registration_bot_create_specific_locationtest_botservice_create_channel_specific_locationManually validate existing functionality
az bot createandaz bot msteams createwithout a locationaz bot create -landaz bot msteams create -lwith "global", "westeurope" or "westus2" as the specified locationHistory Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.