This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: don't use upx to compress built binaries #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboersma
approved these changes
Jul 8, 2021
jadarsie
approved these changes
Jul 8, 2021
jackfrancis
added a commit
that referenced
this pull request
Jul 8, 2021
jackfrancis
added a commit
that referenced
this pull request
Jul 12, 2021
jackfrancis
added a commit
that referenced
this pull request
Jul 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR abandons the goal of compressing built binaries using upx. We've experienced reports of non-executable binaries after processing with upx, and it is a known outcome of depending upon upx that updates to the version of golang may require an update to upx. We'd rather optimize our ability to quickly track version movement in golang itself, and not be held back by golang <---> upx affinity.
Issue Fixed:
Fixes #4513
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: