-
Notifications
You must be signed in to change notification settings - Fork 522
feat: add hosts config agent support for Windows nodes #3572
Conversation
the first commit is coming from #3556, needs a rebase after it gets merged. |
131911a
to
e0f94a6
Compare
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
e0f94a6
to
e716b58
Compare
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Look like there was at least one debugging TODO left. Also want to minimize the noise in the logs so we don't fill them up since the call runs regularly. A rebase will be need for recent changes to the powershell. We moved the powershell scripts due to signing requirements: #3441. There are instructions in the PR that demonstrate where the PS should live, how to test and how to make updates but the functionality itself should stay similar. Let me know if you have questions. |
e716b58
to
e001552
Compare
e001552
to
8f4f6f2
Compare
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
8f4f6f2
to
89111af
Compare
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #3572 /- ##
=======================================
Coverage 73.16% 73.17%
=======================================
Files 147 147
Lines 25097 25110 13
=======================================
Hits 18362 18373 11
- Misses 5604 5605 1
- Partials 1131 1132 1
Continue to review full report at Codecov.
|
@jsturtevant could you help to have a look again? |
89111af
to
56a665a
Compare
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
@jsturtevant could you help to have a look again? |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: feiskyer, jsturtevant The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Follow up of #3556: add hosts config agent support for Windows nodes
Issue Fixed:
Requirements:
Notes: