Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP Method Overrides #128

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

gpatryk
Copy link

@gpatryk gpatryk commented Dec 3, 2018

Fixes #127.

@msftclas
Copy link

msftclas commented Dec 3, 2018

CLA assistant check
All CLA requirements met.

gpatryk pushed a commit to gpatryk/Azurite that referenced this pull request Dec 7, 2018
gpatryk pushed a commit to gpatryk/Azurite that referenced this pull request Dec 7, 2018
@AleF83
Copy link

AleF83 commented Apr 3, 2019

Very helpful PR!
When will this PR be merged?

@AleF83 AleF83 mentioned this pull request Apr 5, 2019
@XiaoningLiu XiaoningLiu added enhancement New feature or request legacy Legacy Azurite V2 and previous versions labels Jun 27, 2019
@edwin-huber edwin-huber changed the base branch from dev to legacy-dev June 28, 2019 18:57
@edwin-huber edwin-huber self-assigned this Jun 28, 2019
@edwin-huber edwin-huber self-requested a review June 28, 2019 18:57
Copy link
Collaborator

@edwin-huber edwin-huber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at support for method override in the service and internally.
No documentation found stating that we support it.
Testing with node SDK did not reveal any issues with the response when the insert or merge are used.

@gpatryk
Copy link
Author

gpatryk commented Jul 5, 2019

Method override was used by Azure Storage SDK for .NET v7.2.1 https://github.com/Azure/azure-storage-net/blob/v7.2.1/Lib/ClassLibraryCommon/Table/Protocol/TableOperationHttpRequestFactory.cs#L72

I don't know if it is still used in newest versions.

@edwin-huber
Copy link
Collaborator

@gpatryk many thanks, we also verified this internally, I'll merge shortly 🥇
As we will only be supporting a very select few method overrides, and this is designed as an emulator not a production service, the risk is minimal.

@edwin-huber edwin-huber merged commit 5ae38d9 into Azure:legacy-dev Jul 8, 2019
edwin-huber added a commit that referenced this pull request Aug 28, 2019
* sped up tests by removing polling

* Fix query single item incorrect behavior

* Fixes incorrect handling of table management URLs

* Ensures only one AzuriteTableRequest is created and processed

* Updated paths so tests don't rely on cloning directory (#105)

Re-targeted to dev branch for pull request...

* Made etag handling same as in microsoft

* Return value collection with only one item when query type is not a single entity query

* Unit test

* Unit test

* Make "initialized" a member of the Environment class

Although the "env" module behaves as a singleton,
the "initialized" variable should be within the object's
definition. This allows better reusability and testing.

* Add tests for Environment class

* Allow 0 to be a valid port number

Passing port number 0 to Node.js' server.listen() will make it assign
an arbitrary unused port.

* Fixes #95

* Disable express' etag generation
* Update entity operations to emit etag according to spec
* Update `EntityIfMatch` to match timestamp instead of etag
* Add unit tests

* merge for #148 poveden:poveden/proper-close

* Fixed merge issues

* removed duplicated Basic_blob_tests

* Method override support

* Support case when RowKey is empty string

* added test and corrected status code

* Add support for HTTP Method Overrides (#128)

* using correct process termination message for cleanup on exit in windows, also applied NPM audit fixes

* merged changes

* Updated release notes for 2.7.1 release

* updated package dependencies with npm audit fix, all tests still passing

* Updated package version

* removed extra -
edwin-huber added a commit that referenced this pull request Feb 4, 2020
* sped up tests by removing polling

* Fix query single item incorrect behavior

* Fixes incorrect handling of table management URLs

* Ensures only one AzuriteTableRequest is created and processed

* Updated paths so tests don't rely on cloning directory (#105)

Re-targeted to dev branch for pull request...

* Made etag handling same as in microsoft

* Return value collection with only one item when query type is not a single entity query

* Unit test

* Unit test

* Make "initialized" a member of the Environment class

Although the "env" module behaves as a singleton,
the "initialized" variable should be within the object's
definition. This allows better reusability and testing.

* Add tests for Environment class

* Allow 0 to be a valid port number

Passing port number 0 to Node.js' server.listen() will make it assign
an arbitrary unused port.

* Fixes #95

* Disable express' etag generation
* Update entity operations to emit etag according to spec
* Update `EntityIfMatch` to match timestamp instead of etag
* Add unit tests

* merge for #148 poveden:poveden/proper-close

* Fixed merge issues

* removed duplicated Basic_blob_tests

* Method override support

* Support case when RowKey is empty string

* added test and corrected status code

* Add support for HTTP Method Overrides (#128)

* using correct process termination message for cleanup on exit in windows, also applied NPM audit fixes

* merged changes

* Escaped quotation marks replacement fix. (#284)

Was also replacing all @ by single quotes, breaking matches with strings containing @ (i.e. email addresses).

* updated release notes

* minor formatting of release note

* updated version in package.json

Co-authored-by: Alex <[email protected]>
Co-authored-by: Phred Lane <[email protected]>
Co-authored-by: Kyle Dodson <[email protected]>
Co-authored-by: Michael Kruglos <3526988 [email protected]>
Co-authored-by: Patryk Grzegorczyk <[email protected]>
Co-authored-by: Jorge Poveda <[email protected]>
Co-authored-by: Alexander Schmidt <[email protected]>
Co-authored-by: Patryk Grzegorczyk <[email protected]>
Co-authored-by: Richard Cognot <[email protected]>
edwin-huber added a commit that referenced this pull request Apr 29, 2020
* sped up tests by removing polling

* Fix query single item incorrect behavior

* Fixes incorrect handling of table management URLs

* Ensures only one AzuriteTableRequest is created and processed

* Updated paths so tests don't rely on cloning directory (#105)

Re-targeted to dev branch for pull request...

* Made etag handling same as in microsoft

* Return value collection with only one item when query type is not a single entity query

* Unit test

* Unit test

* Make "initialized" a member of the Environment class

Although the "env" module behaves as a singleton,
the "initialized" variable should be within the object's
definition. This allows better reusability and testing.

* Add tests for Environment class

* Allow 0 to be a valid port number

Passing port number 0 to Node.js' server.listen() will make it assign
an arbitrary unused port.

* Fixes #95

* Disable express' etag generation
* Update entity operations to emit etag according to spec
* Update `EntityIfMatch` to match timestamp instead of etag
* Add unit tests

* merge for #148 poveden:poveden/proper-close

* Fixed merge issues

* removed duplicated Basic_blob_tests

* Method override support

* Support case when RowKey is empty string

* added test and corrected status code

* Add support for HTTP Method Overrides (#128)

* using correct process termination message for cleanup on exit in windows, also applied NPM audit fixes

* merged changes

* Escaped quotation marks replacement fix. (#284)

Was also replacing all @ by single quotes, breaking matches with strings containing @ (i.e. email addresses).

* updated release notes

* minor formatting of release note

* updated version in package.json

* updated legacy dev readme to remove references to old arafato docker hub entry and point to v3 for all needs other than table storage (#393)

Co-authored-by: Alex <[email protected]>
Co-authored-by: Phred <[email protected]>
Co-authored-by: Alex Swan <[email protected]>
Co-authored-by: Kyle Dodson <[email protected]>
Co-authored-by: Michael Kruglos <[email protected]>
Co-authored-by: Patryk Grzegorczyk (CodeTwo) <[email protected]>
Co-authored-by: Jorge Poveda <[email protected]>
Co-authored-by: Alexander Schmidt <[email protected]>
Co-authored-by: Edwin Huber <[email protected]>
Co-authored-by: Patryk Grzegorczyk <[email protected]>
Co-authored-by: Richard Cognot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request legacy Legacy Azurite V2 and previous versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants