-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HTTP Method Overrides #128
Conversation
Return queue length with metadata
Very helpful PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at support for method override in the service and internally.
No documentation found stating that we support it.
Testing with node SDK did not reveal any issues with the response when the insert or merge are used.
Method override was used by Azure Storage SDK for .NET v7.2.1 https://github.com/Azure/azure-storage-net/blob/v7.2.1/Lib/ClassLibraryCommon/Table/Protocol/TableOperationHttpRequestFactory.cs#L72 I don't know if it is still used in newest versions. |
@gpatryk many thanks, we also verified this internally, I'll merge shortly 🥇 |
* sped up tests by removing polling * Fix query single item incorrect behavior * Fixes incorrect handling of table management URLs * Ensures only one AzuriteTableRequest is created and processed * Updated paths so tests don't rely on cloning directory (#105) Re-targeted to dev branch for pull request... * Made etag handling same as in microsoft * Return value collection with only one item when query type is not a single entity query * Unit test * Unit test * Make "initialized" a member of the Environment class Although the "env" module behaves as a singleton, the "initialized" variable should be within the object's definition. This allows better reusability and testing. * Add tests for Environment class * Allow 0 to be a valid port number Passing port number 0 to Node.js' server.listen() will make it assign an arbitrary unused port. * Fixes #95 * Disable express' etag generation * Update entity operations to emit etag according to spec * Update `EntityIfMatch` to match timestamp instead of etag * Add unit tests * merge for #148 poveden:poveden/proper-close * Fixed merge issues * removed duplicated Basic_blob_tests * Method override support * Support case when RowKey is empty string * added test and corrected status code * Add support for HTTP Method Overrides (#128) * using correct process termination message for cleanup on exit in windows, also applied NPM audit fixes * merged changes * Updated release notes for 2.7.1 release * updated package dependencies with npm audit fix, all tests still passing * Updated package version * removed extra -
* sped up tests by removing polling * Fix query single item incorrect behavior * Fixes incorrect handling of table management URLs * Ensures only one AzuriteTableRequest is created and processed * Updated paths so tests don't rely on cloning directory (#105) Re-targeted to dev branch for pull request... * Made etag handling same as in microsoft * Return value collection with only one item when query type is not a single entity query * Unit test * Unit test * Make "initialized" a member of the Environment class Although the "env" module behaves as a singleton, the "initialized" variable should be within the object's definition. This allows better reusability and testing. * Add tests for Environment class * Allow 0 to be a valid port number Passing port number 0 to Node.js' server.listen() will make it assign an arbitrary unused port. * Fixes #95 * Disable express' etag generation * Update entity operations to emit etag according to spec * Update `EntityIfMatch` to match timestamp instead of etag * Add unit tests * merge for #148 poveden:poveden/proper-close * Fixed merge issues * removed duplicated Basic_blob_tests * Method override support * Support case when RowKey is empty string * added test and corrected status code * Add support for HTTP Method Overrides (#128) * using correct process termination message for cleanup on exit in windows, also applied NPM audit fixes * merged changes * Escaped quotation marks replacement fix. (#284) Was also replacing all @ by single quotes, breaking matches with strings containing @ (i.e. email addresses). * updated release notes * minor formatting of release note * updated version in package.json Co-authored-by: Alex <[email protected]> Co-authored-by: Phred Lane <[email protected]> Co-authored-by: Kyle Dodson <[email protected]> Co-authored-by: Michael Kruglos <3526988 [email protected]> Co-authored-by: Patryk Grzegorczyk <[email protected]> Co-authored-by: Jorge Poveda <[email protected]> Co-authored-by: Alexander Schmidt <[email protected]> Co-authored-by: Patryk Grzegorczyk <[email protected]> Co-authored-by: Richard Cognot <[email protected]>
* sped up tests by removing polling * Fix query single item incorrect behavior * Fixes incorrect handling of table management URLs * Ensures only one AzuriteTableRequest is created and processed * Updated paths so tests don't rely on cloning directory (#105) Re-targeted to dev branch for pull request... * Made etag handling same as in microsoft * Return value collection with only one item when query type is not a single entity query * Unit test * Unit test * Make "initialized" a member of the Environment class Although the "env" module behaves as a singleton, the "initialized" variable should be within the object's definition. This allows better reusability and testing. * Add tests for Environment class * Allow 0 to be a valid port number Passing port number 0 to Node.js' server.listen() will make it assign an arbitrary unused port. * Fixes #95 * Disable express' etag generation * Update entity operations to emit etag according to spec * Update `EntityIfMatch` to match timestamp instead of etag * Add unit tests * merge for #148 poveden:poveden/proper-close * Fixed merge issues * removed duplicated Basic_blob_tests * Method override support * Support case when RowKey is empty string * added test and corrected status code * Add support for HTTP Method Overrides (#128) * using correct process termination message for cleanup on exit in windows, also applied NPM audit fixes * merged changes * Escaped quotation marks replacement fix. (#284) Was also replacing all @ by single quotes, breaking matches with strings containing @ (i.e. email addresses). * updated release notes * minor formatting of release note * updated version in package.json * updated legacy dev readme to remove references to old arafato docker hub entry and point to v3 for all needs other than table storage (#393) Co-authored-by: Alex <[email protected]> Co-authored-by: Phred <[email protected]> Co-authored-by: Alex Swan <[email protected]> Co-authored-by: Kyle Dodson <[email protected]> Co-authored-by: Michael Kruglos <[email protected]> Co-authored-by: Patryk Grzegorczyk (CodeTwo) <[email protected]> Co-authored-by: Jorge Poveda <[email protected]> Co-authored-by: Alexander Schmidt <[email protected]> Co-authored-by: Edwin Huber <[email protected]> Co-authored-by: Patryk Grzegorczyk <[email protected]> Co-authored-by: Richard Cognot <[email protected]>
Fixes #127.