Fix Avalonia/references generation #16427
Conversation
|
You can test this PR using the following package version. |
|
Ugh, nasty. I removed generation of the file because it didn't (appear to) have any further purpose once the external MSBuild processes were removed. The dependency hidden in the VS extension repo was undocumented. |
It wasn't even there until a few months before your PR, and wasn't a part of a stable release of the extension until after 11.1.0! Just an unfortunate set of circumstances really. IMO depending on this file in the VS extension is a hack and dependencies should be detected properly, but there's no time for that right now. |
|
You can test this PR using the following package version. |
Co-authored-by: Steven Kirk <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
What does the pull request do?
Fixes intellisense in the latest version of the VS extension.
AvaloniaUI/AvaloniaVS#413 made a change to the VS extension that required the
referencesfile but #14700 removed the generation of that file (I assume accidentally). #14397 attempted to fix that but it looks like it didn't actually fix it - it was always skipped when it shouldn't be and not skipped when it should be.This wasn't detected because 11.1.0 was tested with the then-current version of the extension which didn't include AvaloniaUI/AvaloniaVS#413. After 11.1.0 was released a new version of the extension was released, and 💥 .