Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT: Center generating content message on mobile #93335

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

xavier-lc
Copy link
Contributor

@xavier-lc xavier-lc commented Aug 7, 2024

Proposed Changes

  • Center the Generating content for your site message on mobile:
Before After
Screenshot from 2024-08-07 17-44-27 image
  • Also, vertically align the spinner with the text on desktop, you can see on the first image that it's a little bit off:
Before After
image image

Testing Instructions

  • Open the live preview
  • Go to /patterns
  • Scroll down to the site layouts
  • Pick one of the layouts
  • Click on Customize content with AI
  • Wait until loading is done
  • Enter a prompt and click on generate content
  • Check that the Generating content for your site. message is properly aligned both on desktop and mobile

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@xavier-lc xavier-lc requested a review from a team as a code owner August 7, 2024 16:02
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 7, 2024
@xavier-lc xavier-lc self-assigned this Aug 7, 2024
@xavier-lc xavier-lc changed the title Fix/generating content message on mobile RT: Center generating content message on mobile Aug 7, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@xavier-lc xavier-lc requested a review from a team August 7, 2024 16:16
@xavier-lc xavier-lc mentioned this pull request Aug 7, 2024
7 tasks
Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/generating-content-message-on-mobile on your sandbox.

@xavier-lc xavier-lc merged commit 798b306 into trunk Aug 7, 2024
18 checks passed
@xavier-lc xavier-lc deleted the fix/generating-content-message-on-mobile branch August 7, 2024 19:58
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants