Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test page to iterate with the chart #93320

Draft
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Draft

Add a test page to iterate with the chart #93320

wants to merge 6 commits into from

Conversation

epeicher
Copy link
Contributor

@epeicher epeicher commented Aug 7, 2024 •
edited
Loading

Resolves https://github.com/Automattic/dotcom-forge/issues/8574

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-116081
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-116081&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-116081&env=a8c-for-agencies

@matticbot
Copy link
Contributor

matticbot commented Aug 7, 2024 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug investigate/single-line-chart on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Aug 7, 2024 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~119 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions          -51 B  (-0.0%)       -2 B  (-0.0%)
entry-login                  -51 B  (-0.0%)       -2 B  (-0.0%)
entry-domains-landing        -51 B  (-0.0%)       -2 B  (-0.0%)
entry-browsehappy            -51 B  (-0.0%)       -2 B  (-0.0%)
entry-stepper                 47 B  ( 0.0%)       56 B  ( 0.0%)
entry-main                    47 B  ( 0.0%)       61 B  ( 0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~64851 bytes added 📈 [gzipped])

name                parsed_size            gzip_size
marketplace            286087 B  ( 30.6%)   100283 B  ( 35.2%)
google-my-business        570 B   ( 0.1%)      143 B   ( 0.1%)
devdocs                   108 B   ( 0.1%)        2 B   ( 0.0%)
stats                     -51 B   (-0.0%)      -12 B   (-0.0%)
site-monitoring           -51 B   (-0.0%)      -64 B   (-0.0%)
site-logs                 -51 B   (-0.0%)      -64 B   (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~3849 bytes removed 📉 [gzipped])

name                                                 parsed_size           gzip_size
async-load-design-playground                               622 B  ( 0.0%)      152 B  ( 0.0%)
async-load-design                                          622 B  ( 0.0%)      152 B  ( 0.0%)
async-load-calypso-my-sites-stats-pages-subscribers        -64 B  (-0.0%)      -34 B  (-0.1%)
async-load-design-blocks                                    42 B  ( 0.0%)      379 B  ( 0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@epeicher
Copy link
Contributor Author

epeicher commented Aug 7, 2024

Current version of the chart b4d4a50 can display the point styles based on the datum
CleanShot 2024-08-07 at 18 07 46@2x

@epeicher
Copy link
Contributor Author

epeicher commented Aug 9, 2024

After adding charts for uPlot here and Chart.js here, this is the test page results for an initial Proof of Concept:

CleanShot 2024-08-09 at 18 00 15@2x

I will update the parent issue with my findings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epeicher @matticbot