Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI Remote Control Fixes #20198

Merged
merged 10 commits into from
Dec 3, 2024
Merged

AI Remote Control Fixes #20198

merged 10 commits into from
Dec 3, 2024

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Nov 26, 2024 •
edited
Loading

Fixes #13267
Fixes #16881
Fixes #14039
Fixes #14062

Also adds QoL where pressing eject on remote controlled mechs exits remote control.

@BotBOREALIS BotBOREALIS added Review Required Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging. labels Nov 26, 2024
@Ben10083
Copy link
Contributor Author

Ben10083 commented Nov 29, 2024 •
edited
Loading

WIP until I can fix spiderbot radios

Fixed

@BotBOREALIS BotBOREALIS added WIP The PR is a work in progress and should not be reviewed yet. and removed Review Required labels Nov 29, 2024
@BotBOREALIS BotBOREALIS added Review Required and removed WIP The PR is a work in progress and should not be reviewed yet. labels Nov 29, 2024
FluffyGhoster
FluffyGhoster requested changes Dec 2, 2024
View reviewed changes
code/modules/tgui/states/default.dm Outdated Show resolved Hide resolved
code/modules/mob/living/silicon/ai/ai.dm Outdated Show resolved Hide resolved
code/modules/mob/living/silicon/ai/ai.dm Show resolved Hide resolved
code/controllers/subsystems/virtual_reality.dm Outdated Show resolved Hide resolved
code/controllers/subsystems/virtual_reality.dm Outdated Show resolved Hide resolved
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Dec 3, 2024
Merged via the queue into Aurorastation:master with commit 534a077 Dec 3, 2024
25 checks passed
@Ben10083 Ben10083 deleted the Remote_Control_Fix branch December 4, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alsoandanswer alsoandanswer alsoandanswer approved these changes

@JohnWildkins JohnWildkins Awaiting requested review from JohnWildkins JohnWildkins is a code owner

@FluffyGhoster FluffyGhoster Awaiting requested review from FluffyGhoster

Assignees
No one assigned
Labels
Awaiting Merge Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging.
Projects
None yet
Milestone
No milestone
5 participants
@Ben10083 @alsoandanswer @FluffyGhoster @NonQueueingMatt @BotBOREALIS